This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Chmod parent dirs when syncing files on Android #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
rosen-vladimirov
suggested changes
Apr 12, 2017
| .map(async localToDevicePathData => { | ||
| const devicePath = localToDevicePathData.getDevicePath(); | ||
| let sections = devicePath.split("/"); | ||
| let parentDir = sections.slice(0, sections.length - 1); |
There was a problem hiding this comment.
instead of splitting and joining, I believe you can use path.dirname(devicePath) - have you tried it?
There was a problem hiding this comment.
I have not, thanks for making me aware of it!
petekanev
force-pushed
the
pete/chmod-livesync-dirs
branch
from
46b0708 to
e65a7c1
Compare
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing files as part of the livesync procedure on Android doesn't always update parent directories' permissions on the device unless the changes require a rebuild of the application, at which point they will be included in a list of files and directories to be chmod`d.
I propose that files being pushed in that temporary directory always have their parent's permissions explicitly set to 777 to allow their removal when necessary.