-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
Description
In attempting to refactor the guide code to work with position guides, I found 8 definitions of what is a position aesthetic, only one of which is used by is_position_aes()
.
Lines 176 to 177 in 1f6f0cb
var[var %in% c("x", "xmin", "xmax", "xend", "xintercept")] <- "x" | |
var[var %in% c("y", "ymin", "ymax", "yend", "yintercept")] <- "y" |
Line 83 in 1f6f0cb
c("x", "xmin", "xmax", "xend", "xintercept", "xmin_final", "xmax_final", "xlower", "xmiddle", "xupper", "x0"), |
Line 102 in 1f6f0cb
c("y", "ymin", "ymax", "yend", "yintercept", "ymin_final", "ymax_final", "lower", "middle", "upper", "y0"), |
Line 63 in 1f6f0cb
sc <- discrete_scale(c("y", "ymin", "ymax", "yend"), "position_d", identity, ..., |
Line 54 in 1f6f0cb
sc <- discrete_scale(c("x", "xmin", "xmax", "xend"), "position_d", identity, ..., |
Lines 42 to 43 in 1f6f0cb
x = x, xmin = xmin, xmax = xmax, xend = xend, | |
y = y, ymin = ymin, ymax = ymax, yend = yend |
Line 142 in 1f6f0cb
c("x", "xmin", "xmax", "xend"), |
Line 179 in 1f6f0cb
c("y", "ymin", "ymax", "yend"), |
Line 291 in 1f6f0cb
if (all(aesthetics %in% c("x", "xmin", "xmax", "xend", "y", "ymin", "ymax", "yend"))) { |
Is there a reason that any of these definitions should be different from the one in scale_(x|y)_continuous()
?