Excessive debug log messages on changes to $scope.markers

[MattSidor]

When the user hovers over a marker, I am changing the marker size and anchor:

    function growMarker(markerName) {
        //double marker icon size and slightly adjust anchor so it stays centered
        $scope.markers[markerName].icon.iconSize = [24,24];
        $scope.markers[markerName].icon.iconAnchor = [11,11];
    }
    function shrinkMarker(markerName) {
        //restore marker icon to original settings
        $scope.markers[markerName].icon.iconSize = [17,17];
        $scope.markers[markerName].icon.iconAnchor = [8,8];
    }

    $scope.$on('leafletDirectiveMarker.mouseover', function (event, args){
        growMarker(args.modelName);
    });
    $scope.$on('leafletDirectiveMarker.mouseout', function (event, args){
        shrinkMarker(args.modelName);
    });

Since a recent update to angular-leaflet-directive, each time a marker's iconSize and iconAnchor properties are changed, my console log gets filled with a debug log message for each and every marker on the map, regardless of whether that specific marker was changed:

[AngularJS - Leaflet] [marker] is already rendered, marker: king
angular.js:12314 
[AngularJS - Leaflet] [marker] is already rendered, marker: mathsci
angular.js:12314 
[AngularJS - Leaflet] [marker] is already rendered, marker: art
angular.js:12314 
[AngularJS - Leaflet] [marker] is already rendered, marker: pes
angular.js:12314 

...etc. I have about 20 markers, so I get 20 errors when I mouseover and 20 errors when I mouseout.

To fix this for now, I've turned off Angular debug logging in my application's configuration (it is turned on by default):

angular.module(ApplicationConfiguration.applicationModuleName).config(['$logProvider',
    function($logProvider) {
        $logProvider.debugEnabled(false);
    }
]);

[nmccready]

It would be better if angular-leaflet internally used an independent logger which disables everything but error by default. Then users can choose to turn it on.

[MattSidor]

Thanks @nmccready, that sounds perfect to me.

[Wilzi]

+1

[nmccready]

About 75% of the way there I ported ui-gmap's logger to https://github.com/nmccready/angular-simple-logger so both code bases will be sharing that dependency.

[nmccready]

PR #915

[MattSidor]

Thank you very much @nmccready

[simison]

Could you add this requirement to README.md as well? https://github.com/tombatossals/angular-leaflet-directive#how-to-use-it
This change isn't mentioned at CHANGELOG.md either.

Actually this would've deserved 0.9 (breaking change) since it requires embedding another file?

It's easy to overlook it as seen at #918

Cheers!

[nmccready]

I was on th fence on versioning but why do you need a Readme. The requirements are in both package.json and Bower.json I think that's clear enough.

[simison]

As I said, it's easy to overlook this ;-) Expect anything from the people — I'm sure we've both seen the dumbest ever questions floating the internets. If you don't want to spend any time in the future directing people to look at that extra file, you could spend 3mins to mention it at those text files. :-)

On more serious tone;
It's easy to miss something like this when just hitting bower update and you have a ton of packages. I always check change logs and I'm even following this repo, so I tend to notice these things.

My staging server's CI on the other hand does npm+bower update and since this version wasn't supposed to be a breaking change, bower would've just bluntly updated this to 0.8.8. (I use ~0.8.7 requirement for this kind of packages to allow minor updates).

Not a biggie but food for thought for the future.

PS. Thanks a bunch working on this! It's an amazing library and I rely a lot on it at @Trustroots.