fix: handle ContentTypeError in dynamic client discovery #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Kubernetes API server returns a 503 Service Unavailable with text/plain content type instead of JSON, the dynamic client was failing with a ContentTypeError while trying to parse the response. This fix catches ContentTypeError in the get_resources_for_api_version method and handles it the same way as ServiceUnavailableError, allowing the client to gracefully continue with an empty resources list. This resolves issues when accessing certain API endpoints that may temporarily return non-JSON responses during service unavailability
tamilhce
changed the title
tamilhce
changed the title
|
Any updates ? |
tomplus
reviewed
Aug 4, 2025
| @@ -183,7 +184,9 @@ async def get_resources_for_api_version(self, prefix, group, version, preferred) | |||
| try: | |||
| response = await self.client.request('GET', path) | |||
| resources_response = response.resources or [] | |||
| except ServiceUnavailableError: | |||
| except (ServiceUnavailableError, ContentTypeError): | |||
There was a problem hiding this comment.
LGTM, thanks for your contribution
tomplus
approved these changes
Aug 4, 2025
|
Could you fix order of imports as Flake suggests? |
Fix import sorting
Fix import sorting
|
Ack. Fixed the import sorting and verified it locally. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
=======================================
Coverage 27.07% 27.07%
=======================================
Files 805 805
Lines 98735 98736 +1
=======================================
+ Hits 26732 26733 +1
Misses 72003 72003 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: handle ContentTypeError in dynamic client discovery
#367
When the Kubernetes API server returns a 503 Service Unavailable with text/plain
content type instead of JSON, the dynamic client was failing with a ContentTypeError
while trying to parse the response. This fix catches ContentTypeError in the
get_resources_for_api_version method and handles it the same way as ServiceUnavailableError,
allowing the client to gracefully continue with an empty resources list.
This resolves issues when accessing certain API endpoints that may temporarily
return non-JSON responses during service unavailability