Updating phone numbers using the API adds a "+1" in front of numbers despite having selected "no country" in the data model

[StephanieJoly4]

Bug Description

• Reported by a customer, I can reproduce locally
• Configuration of the data model is phone / "No country" selected when configuring the country code.
• When adding a phone number in a record using the UI, for example "+10987654321", I see this exact string in the phone field.
• However when I test updating this field using the API, I get "+1+10987654321".

Example:
I ran my tests in the "Customer playground" workspace, associated with my email.
Here is the workflow I used for the API call.

Expected behavior

The API calls updates the record with the value "+10987654321"

[MohitAgrawal16]

Hey @StephanieJoly4, can I work on this issue? I have experience with open-source contributions and am also familiar with API handling.

[StephanieJoly4]

Hi @MohitAgrawal16 , thanks for reaching out! Yes please feel free to share a PR and our engineering team will review it !

[ijreilly]

@lucasbordeau @bosiraphael @charlesBochet @guillim fyi

[MohitAgrawal16]

@StephanieJoly4, can I get access to the test workflow?
my email: mohitagrawal1684@gmail.com

And the issue is yet to be solved?

[prastoin]

Hey @MohitAgrawal16 thanks for your interest in this issue ! We're about to manage this internally for the moment

[prastoin]

Update

The issue in the workflow is that the API is hit with the following input:

    const updates = [
      {
        "id": "5d70a568-7f40-46e8-b6e7-8356d166b397",
        "phones": { // replace here with the field from Opportunity to point to the People record(s)
          "primaryPhoneNumber": "+10987654321"
        }
      }
    ];

Whereas it should be

   const updates = [
      {
        "id": "5d70a568-7f40-46e8-b6e7-8356d166b397",
        "phones": { // replace here with the field from Opportunity to point to the People record(s)
          "primaryPhoneNumber": "0987654321"
          "primaryPhoneCountryCode": 'US',
          "primaryPhoneCallingCode": '+1',
        }
      }
    ];

Should we implement a stricter validation regarding the fieldPhoneNumber integrity ? or is it expected for them to contains special characters ? @Bonapara

[prastoin]

Discussed with @charlesBochet and @Bonapara

Summary

We will now infer the primaryPhoneCountryCode primaryPhoneCallingCode from the primaryPhoneNumber
If both of the information are retrievable from the two fields and conflicting then we would throw an exception

We also need to bring the same number validation grain level as the one the frontend does using the phoneLib external library.

Coverage

We should implement a basic coverage on both GRAPHQL and REST apis

We still need to determine what to do with additionalPhones

[StephanieJoly4]

cc @vickywxng as something that could be described in our documentation as this is not clear today for users how to format their API call to update phone numbers
thank you!