Skip to content

Fix integration test ci #10226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2025
Merged

Fix integration test ci #10226

merged 6 commits into from
Feb 17, 2025

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Feb 14, 2025

Context

Integration test ci was not running properly. This PR should fix that

Todo: This was not running for a while, many tests are not succeeding so I'll try to fix them in this PR now that the action is running properly.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the server integration test command format in CI workflows to use NX's preferred configuration flag syntax.

  • Modified .github/workflows/ci-server.yaml to use --configuration=with-db-reset instead of :with-db-reset suffix for better NX compatibility
  • Changed test command from test:integration:with-db-reset to test:integration --configuration=with-db-reset

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit 2ba9f2d into main Feb 17, 2025
30 of 32 checks passed
@charlesBochet charlesBochet deleted the c--fix-integration-tests-ci branch February 17, 2025 10:45
eliezer-rodrigues037 pushed a commit to mind-developer/kvoip-v2 that referenced this pull request Feb 17, 2025
## Context
Integration test ci was not running properly. This PR should fix that

Todo: This was not running for a while, many tests are not succeeding so
I'll try to fix them in this PR now that the action is running properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants