Fix workflow run ouput format #10302
Conversation
Devessier
force-pushed
the
fix-workflow-run-ouput-format
branch
from
5cf0cd0 to
37db4dc
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the workflow run output format across the frontend and backend to improve workflow execution tracking and visualization.
- Changed
WorkflowRunOutputtype in/packages/twenty-front/src/modules/workflow/types/Workflow.tsto include aflowobject withtriggerandsteps, makingstepsOutputoptional - Simplified
WorkflowRunVisualizerEffectin/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunVisualizerEffect.tsxto use workflow run output directly - Added optional chaining for
stepsOutputaccess in/packages/twenty-server/src/modules/workflow/workflow-executor/workspace-services/workflow-executor.workspace-service.tsto prevent runtime errors - Re-enabled 'Flow' tab for workflow run views in
/packages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowContainerTabs.ts - Updated test cases in
/packages/twenty-front/src/modules/workflow/workflow-diagram/utils/__tests__/generateWorkflowRunDiagram.test.tsto reflect new output format
8 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| title: 'Flow', | ||
| position: 0, | ||
| Icon: IconSettings, |
There was a problem hiding this comment.
logic: Both workflowRunOutput and workflowRunFlow tabs have position 0, which could cause unpredictable tab ordering
| attemptCount: 1, | ||
| result: undefined, | ||
| error: '', | ||
| }, |
There was a problem hiding this comment.
style: Empty error string treated as failure state. Consider using undefined for consistency with other error cases.
| @@ -231,7 +231,7 @@ export class WorkflowVisualizerPage { | |||
|
|
|||
| async closeSidePanel() { | |||
| const closeButton = this.#page.getByTestId( | |||
| 'page-header-close-command-menu-button', | |||
| 'page-header-command-menu-button', | |||
There was a problem hiding this comment.
My change concerns the e2e tests, and I'm not responsible for the renaming. However, I think it's due to Raphaël's recent changes on the Cmd+K close button. I assume the Open and Closed states are now the same button, hence a more global test id. (close-button -> button)
|
Thanks @Devessier for your contribution! |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Uh oh!
There was an error while loading. Please reload this page.