Fix buttons size #10620
Merged
Fix buttons size #10620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasbordeau
approved these changes
Mar 3, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR restores the button size attribute that was accidentally removed in PR #10536, ensuring small buttons render at 24px height instead of all buttons defaulting to 32px.
- Fixed
packages/twenty-ui/src/input/button/components/Button/Button.tsxby adding back thesizeprop to theStyledButtoncomponent on line 469 - The height logic on line 342 now properly applies (
size === 'small' ? '24px' : '32px') based on the size prop - Reordered imports at the top of the file for better organization
- This fix maintains consistency with other button components in the codebase that support size variations
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
AMoreaux
pushed a commit
that referenced
this pull request
Mar 3, 2025
The button size attribute was removed accidentally in this PR #10536, I'm putting it back. All the buttons were 32px instead of 24px for the small ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button size attribute was removed accidentally in this PR #10536, I'm putting it back.
All the buttons were 32px instead of 24px for the small ones.