Remove hotkey scope from useListenClickOutside #11098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
approved these changes
Mar 21, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR simplifies click-outside detection by removing hotkey scope functionality from the useListenClickOutside hook, addressing bugs related to side panel interactions.
- Removed
hotkeyScopeparameter and associated logic frompackages/twenty-front/src/modules/ui/utilities/pointer-event/hooks/useListenClickOutside.ts - Removed
internalHotkeysEnabledScopesStatedependency for cleaner click-outside detection - Updated
CommandMenuContainer.tsxto removeAppHotkeyScope.CommandMenuOpenparameter - Click-outside events now trigger regardless of current hotkey scope state
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -1,7 +1,6 @@ | |||
| import React, { useEffect } from 'react'; | |||
| import { useRecoilCallback } from 'recoil'; | |||
|
|
|||
| import { internalHotkeysEnabledScopesState } from '@/ui/utilities/hotkey/states/internal/internalHotkeysEnabledScopesState'; | |||
| import { useClickOustideListenerStates } from '@/ui/utilities/pointer-event/hooks/useClickOustideListenerStates'; | |||
There was a problem hiding this comment.
syntax: typo in import path: 'useClickOustideListenerStates' should be 'useClickOutsideListenerStates'
charlesBochet
deleted the
r--remove-hotkey-scope-from-useListenClickOutside
branch
ijreilly
pushed a commit
that referenced
this pull request
Mar 24, 2025
The old `useListenClickOutside` API allowed us to pass a hotkeyScope as a parameter, the click outside was triggered only if the current hotkey scope matched the parameter. We don't want this anymore. This fixes a few bugs related to hotkey scopes inside the side panel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
useListenClickOutsideAPI allowed us to pass a hotkeyScope as a parameter, the click outside was triggered only if the current hotkey scope matched the parameter. We don't want this anymore. This fixes a few bugs related to hotkey scopes inside the side panel.