Skip to content

Generate more random subdomains #11249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Mar 27, 2025

Sorted the 2 existing lists + added a new colors list to generate the random subdomain to have less collision

Screenshot 2025-03-27 at 19 25 28

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated the random subdomain generator to return a three-part format (prefix-color-suffix) for increased variability.

  • Modified file: /packages/twenty-server/src/engine/core-modules/domain-manager/utils/generate-random-subdomain.ts now includes a random color selection.
  • Ensure tests and function consumers are updated to expect the new "prefix-color-suffix" format.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Weiko Weiko merged commit 976c6af into main Mar 27, 2025
32 checks passed
@Weiko Weiko deleted the c--generate-more-random-subdomains branch March 27, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants