-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Implement sub-field filtering on CURRENCY field type #11726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR implements comprehensive sub-field filtering for CURRENCY field type, focusing on separate filtering capabilities for currency codes and amounts.
- Added
ObjectFilterDropdownCurrencySelect
component for multi-currency code filtering with search functionality - Implemented specialized filtering logic for
amountMicros
andcurrencyCode
sub-fields incomputeViewRecordGqlOperationFilter
- Centralized currency handling with new
CURRENCIES
constant andCurrency
type definition - Removed "Any currency field" option for better UX and added specific icons for currency sub-fields
- Fixed bug with empty filter values (
[]
) and improved emptiness operand handling
49 file(s) reviewed, 28 comment(s)
Edit PR Review Bot Settings | Greptile
...t/src/modules/object-record/advanced-filter/components/AdvancedFilterDropdownFilterInput.tsx
Outdated
Show resolved
Hide resolved
...enty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterValueInput.tsx
Outdated
Show resolved
Hide resolved
...c/modules/object-record/object-filter-dropdown/components/MultipleFiltersDropdownContent.tsx
Show resolved
Hide resolved
...dules/object-record/object-filter-dropdown/components/ObjectFilterDropdownCurrencySelect.tsx
Outdated
Show resolved
Hide resolved
...dules/object-record/object-filter-dropdown/components/ObjectFilterDropdownCurrencySelect.tsx
Outdated
Show resolved
Hide resolved
.../settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/spreadsheet-import/components/MatchColumnToFieldSelect.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/input/components/internal/types/Currency.ts
Show resolved
Hide resolved
...rc/modules/ui/input/components/internal/currency/components/CurrencyPickerDropdownSelect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/EditableFilterChip.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a couple of comments to address before merging
...enty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterValueInput.tsx
Outdated
Show resolved
Hide resolved
...dules/object-record/object-filter-dropdown/components/ObjectFilterDropdownCurrencySelect.tsx
Outdated
Show resolved
Hide resolved
...dules/object-record/object-filter-dropdown/components/ObjectFilterDropdownCurrencySelect.tsx
Outdated
Show resolved
Hide resolved
...y-front/src/modules/object-record/record-filter/utils/computeViewRecordGqlOperationFilter.ts
Outdated
Show resolved
Hide resolved
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:33803 This environment will automatically shut down when the PR is closed or after 5 hours. |
This PR implements sub-field filtering on CURRENCY field type and improves many related zones.
Testing :
Improvements :
Miscellaneous :
Fixes a bug where Empty and Not weren't appearing in filter chip in particular cases
Fixes twentyhq/core-team-issues#498
Fixes #7558