Table hover and click outside fixes #11737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances table interaction behavior by improving hover state management and click-outside handling in the record table component.
- Added hover state cleanup in
useLeaveTableFocus.tsby resettingrecordTableHoverPositionComponentStateto null when focus is lost - Implemented
onMouseLeavehandler inRecordTableBodyDroppable.tsxto clear hover position when mouse leaves table body - Removed conditional rendering of
RecordTableBodyFocusClickOutsideEffectinRecordTableBodyEffectsWrapper.tsxto ensure click-outside handling is always active
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Un piccolo regalo Enregistrement.de.l.ecran.2025-04-25.a.15.08.53.mov |
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:61645 This environment will automatically shut down when the PR is closed or after 5 hours. |
lucasbordeau
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table hover and click outside fixes
This PR improves table interaction behavior by refining cell hover states and click-outside handling in the record table component.
Changes
Click Outside Handling
RecordTableBodyFocusClickOutsideEffectHover State Management
Implemented hover state cleanup in multiple components:
recordTableHoverPositionstate reset inuseLeaveTableFocushookRecordTableBodyDroppableto clear hover positionFixes double focus bug
Videos
Before
Enregistrement.de.l.ecran.2025-04-25.a.15.01.05.mov
After
Enregistrement.de.l.ecran.2025-04-25.a.15.00.04.mov