Fix aggregate operation update on dates on kanban views #12115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a type mismatch in aggregate operation handling for kanban views, particularly focusing on date operations like 'earliest/latest'.
- Fixed state management in
packages/twenty-front/src/modules/views/hooks/useUpdateViewAggregate.tsto store original operation inrecordIndexKanbanAggregateOperationStatewhile using converted operation for view updates - Added test coverage in
packages/twenty-front/src/modules/views/hooks/__tests__/useUpdateViewAggregate.test.tsxto verify correct conversion ofDATE_AGGREGATE_OPERATIONS.earliesttoAGGREGATE_OPERATIONS.min
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:29972 This environment will automatically shut down when the PR is closed or after 5 hours. |
thomtrp
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes twentyhq/core-team-issues#968