fixing a microsoft graph api error #12154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes Microsoft Graph API error handling by adding null checks for email addresses in the message import service.
- Added
.filter(Boolean)totoRecipients,ccRecipients, andbccRecipientsinpackages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service.tsto prevent undefined values - Added fallback empty string for
from.emailAddress.addressto handle cases where sender information is missing - Added participant email validation check with
handle.includes('@')to ensure only valid email addresses are processed
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...essaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:8440 This environment will automatically shut down when the PR is closed or after 5 hours. |
Weiko
reviewed
May 21, 2025
...essaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service.ts
Outdated
Show resolved
Hide resolved
...essaging/message-import-manager/drivers/microsoft/services/microsoft-get-messages.service.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
May 21, 2025
github-project-automation
bot
moved this from 🏗 In Progress
to 🔦 In QA
in 🎯 Roadmap & Sprints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is "Microsoft Graph API unknown error: TypeError: Cannot read properties of undefined (reading 'emailAddress')"
Sentry : https://twenty-v7.sentry.io/issues/6605750776/events/7feb4f5949a64ab78bb429cffb7f0fea/?project=4507072499810304
Fixes twentyhq/core-team-issues#981