Reverting broken filter from #12352
Merged
Reverting broken filter from #12352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reverts changes that introduced bugs in filter functionality, focusing on proper filter initialization and state management.
- Added
hasInitializedCurrentRecordFiltersComponentFamilyState.tsto track per-view filter initialization usingRecordFiltersComponentInstanceContext - Modified
ViewBarRecordFilterEffect.tsxto useuseRecoilComponentFamilyStateV2instead ofuseRecoilComponentStateV2for better state management - Removed
isDeeplyEqualcheck in filter updates to prevent unnecessary re-renders - Added similar initialization tracking for filter groups and sorts in
ViewBarRecordFilterGroupEffectandViewBarRecordSortEffect - Improved view bar details component to handle filter state changes more efficiently
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
...nty-front/src/modules/views/states/hasInitializedCurrentRecordFiltersComponentFamilyState.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/ViewBarRecordFilterEffect.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/ViewBarRecordFilterEffect.tsx
Outdated
Show resolved
Hide resolved
jordan-chalupka
pushed a commit
to InsurOS/twenty
that referenced
this pull request
May 28, 2025
# Introdution Reverting introduced bug by twentyhq#12082 We need to address the bug that was "fixed" by this in order to refresh the recordFilters state, will have a look with @lucasbordeau 🙏
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
# Introdution Reverting introduced bug by twentyhq#12082 We need to address the bug that was "fixed" by this in order to refresh the recordFilters state, will have a look with @lucasbordeau 🙏
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
# Introdution Reverting introduced bug by twentyhq#12082 We need to address the bug that was "fixed" by this in order to refresh the recordFilters state, will have a look with @lucasbordeau 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introdution
Reverting introduced bug by #12082
We need to address the bug that was "fixed" by this in order to refresh the recordFilters state, will have a look with @lucasbordeau 🙏