Fixed non advanced filter creation from table header dropdown #12369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified filter creation logic in table header to allow creation of non-advanced filters even when the same field exists in advanced filters.
- Updated
packages/twenty-front/src/modules/object-record/record-table/record-table-header/hooks/useOpenRecordFilterChipFromTableHeader.tsto only check for duplicate filters whenrecordFilterGroupIdis undefined, fixing edge case where users couldn't create non-advanced filters if they existed in advanced filters
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:13274 This environment will automatically shut down when the PR is closed or after 5 hours. |
jordan-chalupka
pushed a commit
to InsurOS/twenty
that referenced
this pull request
Jun 1, 2025
…hq#12369) This PR fixes a edge case where the user tries to create a non-advanced filter that already exists in advanced filters, from the table header drodpown. This was because the hook that handles the creation was checking for duplicate filters but without discerning between advanced and non-advanced, and we want to be able to create non-advanced filters no matter what we have in advanced filters. Fixes twentyhq#12316
jordan-chalupka
pushed a commit
to InsurOS/twenty
that referenced
this pull request
Jun 1, 2025
…hq#12369) This PR fixes a edge case where the user tries to create a non-advanced filter that already exists in advanced filters, from the table header drodpown. This was because the hook that handles the creation was checking for duplicate filters but without discerning between advanced and non-advanced, and we want to be able to create non-advanced filters no matter what we have in advanced filters. Fixes twentyhq#12316
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
…hq#12369) This PR fixes a edge case where the user tries to create a non-advanced filter that already exists in advanced filters, from the table header drodpown. This was because the hook that handles the creation was checking for duplicate filters but without discerning between advanced and non-advanced, and we want to be able to create non-advanced filters no matter what we have in advanced filters. Fixes twentyhq#12316
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
…hq#12369) This PR fixes a edge case where the user tries to create a non-advanced filter that already exists in advanced filters, from the table header drodpown. This was because the hook that handles the creation was checking for duplicate filters but without discerning between advanced and non-advanced, and we want to be able to create non-advanced filters no matter what we have in advanced filters. Fixes twentyhq#12316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a edge case where the user tries to create a non-advanced filter that already exists in advanced filters, from the table header drodpown.
This was because the hook that handles the creation was checking for duplicate filters but without discerning between advanced and non-advanced, and we want to be able to create non-advanced filters no matter what we have in advanced filters.
Fixes #12316