Add tests on granular settings permissions

[ijreilly]

Closes twentyhq/core-team-issues#605

Actually settingsPermissions checks were already implemented, but we had no tests on them.

In the ticket we had mentioned
TO DO: in pemissions.service we should stop calling userRoleService.getRolesByUserWorkspaces and call getRoleIdForUserWorkspace instead which relies on the cache.
But actually roleId is not enough for settings permissions because we don't store them in the cache (unlien object records permissions - which I think we had forgotten about when adding that TODO.), so we will still need to make a db call to load the role's settingsPermissions. I think it's better to make just one db call to get the role and settingsPermissions from userWorkspaceId (as currently) than to make one redis call to get roleId for userWorksapce then one db call to get role and its settingsPermissions).

[greptile-apps]

PR Summary

Added comprehensive integration tests for granular settings permissions, focusing on role-based access control and permission management.

• Added tests in /packages/twenty-server/test/integration/graphql/suites/settings-permissions/granular-settings-permissions.ts to verify data model and workspace operations for custom roles
• Implemented test cases for permission inheritance, ensuring canUpdateAllSettings=false is properly overridden by specific setting permissions
• Added validation for dynamic permission updates, testing the ability to add/remove setting permissions from existing roles
• Included proper test setup/teardown with Permissions V2 feature flag management
• Added test coverage for denied operations, verifying proper error handling when users lack required permissions

_{1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

logic: Unsafe type assertion with 'any'. Consider adding type guard or error handling if role is not found.

Suggested change

	originalMemberRoleId = rolesResponse.body.data.getRoles.find(
	(role: any) => role.label === 'Member',
	).id;
	const memberRole = rolesResponse.body.data.getRoles.find(
	(role: any) => role.label === 'Member',
	);
	if (!memberRole) throw new Error('Member role not found');
	originalMemberRoleId = memberRole.id;

[greptile-apps]

logic: Add error handling for case where customRole is not found in getRoles response

Suggested change

	const customRole = response.body.data.getRoles.find(
	(role: any) => role.id === customRoleId,
	);
	const customRole = response.body.data.getRoles.find(
	(role: any) => role.id === customRoleId,
	);
	if (!customRole) throw new Error('Custom role not found');

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:17340

This environment will automatically shut down when the PR is closed or after 5 hours.

[Weiko]

LGTM, thanks for improving the coverage!