Hide search again #12539
Merged
Hide search again #12539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Temporarily removes the 'Search Records' action from workflow functionality by commenting it out in packages/twenty-front/src/modules/workflow/workflow-steps/workflow-actions/constants/RecordActions.ts.
- Lacks proper documentation or explanation for removing the FIND_RECORDS action type from RECORD_ACTIONS array
- Missing context about why the search feature is being temporarily disabled
- Added TODO comment suggests future reinstatement but without timeline or requirements
- Could break existing workflows that depend on FIND_RECORDS action type
- Should include deprecation notice or migration guide for affected users
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+26
to
+31
| // TODO: Add search records action | ||
| // { | ||
| // label: 'Search Records', | ||
| // type: 'FIND_RECORDS', | ||
| // icon: 'IconSearch', | ||
| // }, |
There was a problem hiding this comment.
logic: Removing FIND_RECORDS breaks type compatibility since it's still included in the type definition on line 7. Either remove it from the type or keep the implementation.
Suggested change
| // TODO: Add search records action | |
| // { | |
| // label: 'Search Records', | |
| // type: 'FIND_RECORDS', | |
| // icon: 'IconSearch', | |
| // }, | |
| // TODO: Add search records action | |
| // { | |
| // label: 'Search Records', | |
| // type: 'FIND_RECORDS', | |
| // icon: 'IconSearch', | |
| // }, |
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:33571 This environment will automatically shut down when the PR is closed or after 5 hours. |
martmull
approved these changes
Jun 11, 2025
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title