Prevent empty form steps #12560
Prevent empty form steps #12560
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added validation to prevent empty form steps in workflow triggers, requiring at least one field in form action inputs.
- Modified
assertFormStepIsValidinpackages/twenty-server/src/modules/workflow/workflow-trigger/utils/assert-version-can-be-activated.util.tsto require non-empty input arrays in form steps - Added new test file with comprehensive coverage for form step validation scenarios
- Made
assertFormStepIsValidfunction exportable for better modularity and testability - Added error handling for empty form inputs using
WorkflowTriggerException
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| if (settings.input.length === 0) { | ||
| throw new WorkflowTriggerException( | ||
| 'Form action must have at least one field', | ||
| WorkflowTriggerExceptionCode.INVALID_WORKFLOW_VERSION, | ||
| ); | ||
| } |
There was a problem hiding this comment.
logic: new validation uses INVALID_WORKFLOW_VERSION error code while similar empty check above uses INVALID_WORKFLOW_TRIGGER - consider using consistent error codes for similar validation types
| type: 'RECORD', | ||
| label: 'Record', |
There was a problem hiding this comment.
style: Use FieldMetadataType.RECORD instead of string literal 'RECORD' to maintain consistency with line 12 and ensure type safety
| type: 'RECORD', | |
| label: 'Record', | |
| type: FieldMetadataType.RECORD, | |
| label: 'Record', |
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:44787 This environment will automatically shut down when the PR is closed or after 5 hours. |
CleanShot.2025-06-12.at.11.17.09.mp4
Related to twentyhq/core-team-issues#1091