Onboarding - delete PENDING_CREATION workspace if billing is deactivated #12704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennejouan
changed the title
…ING_CREATION workspace has deactivated sub
etiennejouan
force-pushed
the
ej/fix-pending-creation
branch
from
f1c23d1 to
f80698a
Compare
etiennejouan
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactors billing webhook functionality into a dedicated billing-webhook core module, adding workspace cleanup for deactivated billing states. Key architectural improvements include:
- Extracted billing webhook handling from
billingmodule into dedicatedbilling-webhookmodule to improve separation of concerns - Added logic to delete workspaces in
PENDING_CREATIONstate when billing is deactivated via webhook - Consolidated all Stripe event transformers and webhook services under the new module while maintaining existing functionality
- Improved webhook controller error handling with specific
BillingExceptioncases - Streamlined module organization by properly grouping related webhook services (alerts, invoices, subscriptions, etc.)
26 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
...ver/src/engine/core-modules/billing-webhook/services/billing-webhook-subscription.service.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:62086 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context details