12690-error-unknown-error-importing-calendar-events-reafcto-required #12711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored calendar event import logic to fix foreign key constraint violations during calendar event synchronization, ensuring events exist before creating associations.
- Introduced new
existingCalendarEventsMapperutility incalendar-event-mapper.util.tsto replace the removedinject-ids-in-calendar-events.util.ts - Restructured
calendar-save-events.service.tsto handle event creation before associations - Added TSDoc comments in
calendar-channel-event-association.workspace-entity.tsexplainingeventExternalIduniqueness - Improved error handling for cases where calendar events are not found during import
4 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
...erver/src/modules/calendar/calendar-event-import-manager/utils/calendar-event-mapper.util.ts
Outdated
Show resolved
Hide resolved
.../src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
Outdated
Show resolved
Hide resolved
.../src/modules/calendar/calendar-event-import-manager/services/calendar-save-events.service.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:60050 This environment will automatically shut down when the PR is closed or after 5 hours. |
| }; | ||
| }); | ||
|
|
||
| const participantsToSave = filteredEventsWithParticipantsCalendarEventId |
There was a problem hiding this comment.
I'm confused by this logic. How updating or saving participants is tied to the fact that the event is already present in DB or not. I would expect us to compare existing participants with new ones?
There was a problem hiding this comment.
It is related to the construction of the submethod that are responsible to handle the participants.
I did not investigate, but I guess it is a simple insert for new events, while there is a comparison to do for the updated ones.
Could be refacto as well
bosiraphael
changed the title
charlesBochet
approved these changes
Jun 19, 2025
guillim
deleted the
git-fetch-origin-git-checkout-12690-error-unknown-error-importing-calendar-events-reafcto-required
branch
ijreilly
pushed a commit
that referenced
this pull request
Jun 19, 2025
…12711) Why : we had an issue impoting events du to CalendarEvents not yet existing while inserting the CalendarChannelAssociation due to inverted method in the service This PR refactors the calendar event import logic by - renaming - splitting utility functions for better clarity and maintainability. - adding TSDoc comments to explain the purpose and uniqueness of the `eventExternalId` field in calendar event associations Fixes #12690 --------- Co-authored-by: Charles Bochet <[email protected]>
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 19, 2025
…wentyhq#12711) Why : we had an issue impoting events du to CalendarEvents not yet existing while inserting the CalendarChannelAssociation due to inverted method in the service This PR refactors the calendar event import logic by - renaming - splitting utility functions for better clarity and maintainability. - adding TSDoc comments to explain the purpose and uniqueness of the `eventExternalId` field in calendar event associations Fixes twentyhq#12690 --------- Co-authored-by: Charles Bochet <[email protected]>
ijreilly
pushed a commit
that referenced
this pull request
Jun 19, 2025
…12711) Why : we had an issue impoting events du to CalendarEvents not yet existing while inserting the CalendarChannelAssociation due to inverted method in the service This PR refactors the calendar event import logic by - renaming - splitting utility functions for better clarity and maintainability. - adding TSDoc comments to explain the purpose and uniqueness of the `eventExternalId` field in calendar event associations Fixes #12690 --------- Co-authored-by: Charles Bochet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why : we had an issue impoting events du to CalendarEvents not yet existing while inserting the CalendarChannelAssociation due to inverted method in the service
This PR refactors the calendar event import logic by
eventExternalIdfield in calendar event associationsFixes #12690