fix(): add loader on signup #12714
Merged
fix(): add loader on signup #12714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced signup form reliability by adding loading state and proper error handling during user registration.
- Modified
handleCredentialsSignUpinpackages/twenty-front/src/modules/auth/hooks/useAuth.tsto return signUp mutation Promise for better error handling - Added loading state check using
form.formState.isSubmittinginSignInUpGlobalScopeForm.tsxto prevent duplicate submissions - Updated MainButton component disabled state to prevent race conditions during signup process
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:40157 This environment will automatically shut down when the PR is closed or after 5 hours. |
FelixMalfait
approved these changes
Jun 19, 2025
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12713