-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add icon select to manual trigger #12724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon select to manual trigger #12724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added icon selection capability to manual workflow triggers, allowing customization of command menu items with user-selected icons.
- Added icon selection UI with search in
WorkflowEditTriggerManualForm.tsx
with proper i18n support and descriptive tooltips - Extended
workflowSchema.ts
and trigger types to support optional icon field in manual trigger settings - Implemented default icon handling in
getManualTriggerDefaultSettings.ts
using 'IconHandMove' - Modified workflow action menu to dynamically display selected icons instead of hardcoded IconSettingsAutomation
- Updated prefill workflows data to include example icon configuration using 'IconUserPlus'
8 files reviewed, 8 comments
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/workflow/validation-schemas/workflowSchema.ts
Show resolved
Hide resolved
packages/twenty-server/src/modules/workflow/workflow-trigger/types/workflow-trigger.type.ts
Show resolved
Hide resolved
packages/twenty-server/src/modules/workflow/workflow-trigger/types/workflow-trigger.type.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/modules/workflow/workflow-trigger/types/workflow-trigger.type.ts
Outdated
Show resolved
Hide resolved
.../twenty-front/src/modules/workflow/workflow-trigger/utils/getManualTriggerDefaultSettings.ts
Show resolved
Hide resolved
...nty-front/src/modules/workflow/workflow-trigger/components/WorkflowEditTriggerManualForm.tsx
Outdated
Show resolved
Hide resolved
...nty-front/src/modules/workflow/workflow-trigger/components/WorkflowEditTriggerManualForm.tsx
Show resolved
Hide resolved
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:16269 This environment will automatically shut down when the PR is closed or after 5 hours. |
d61221a
to
cc66937
Compare
63c890a
to
92d0ae1
Compare
92d0ae1
to
793d439
Compare
0ac61b4
to
6d1d4ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new icon select looks really clean to me! Let's just confirm the API choice about the description, I don't feel that confident about it.
...ction-menu/actions/record-actions/run-workflow-actions/hooks/useRunWorkflowRecordActions.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/input/components/Select.tsx
Outdated
Show resolved
Hide resolved
...nty-front/src/modules/workflow/workflow-trigger/components/WorkflowEditTriggerManualForm.tsx
Outdated
Show resolved
Hide resolved
...ty-front/src/modules/workflow/workflow-trigger/constants/ManualTriggerAvailabilityOptions.ts
Show resolved
Hide resolved
...rc/modules/workflow/workflow-trigger/utils/__tests__/getManualTriggerDefaultSettings.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## After <img width="1220" alt="image" src="https://github.com/user-attachments/assets/98a73aae-80d7-4e92-93d3-be13210da88b" /> <img width="1131" alt="image" src="https://github.com/user-attachments/assets/9919e415-4355-4995-8979-9055b821f1e9" /> <img width="1300" alt="image" src="https://github.com/user-attachments/assets/27f11cb3-d72c-468a-a641-8414172b9b54" /> <img width="1353" alt="image" src="https://github.com/user-attachments/assets/2f0037f2-fe17-48b6-b7e6-c7528687a5fd" />
After