Skip to content

Add icon select to manual trigger #12724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 19, 2025

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Jun 19, 2025

After

image image image image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added icon selection capability to manual workflow triggers, allowing customization of command menu items with user-selected icons.

  • Added icon selection UI with search in WorkflowEditTriggerManualForm.tsx with proper i18n support and descriptive tooltips
  • Extended workflowSchema.ts and trigger types to support optional icon field in manual trigger settings
  • Implemented default icon handling in getManualTriggerDefaultSettings.ts using 'IconHandMove'
  • Modified workflow action menu to dynamically display selected icons instead of hardcoded IconSettingsAutomation
  • Updated prefill workflows data to include example icon configuration using 'IconUserPlus'

8 files reviewed, 8 comments
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Jun 19, 2025

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:16269

This environment will automatically shut down when the PR is closed or after 5 hours.

@martmull martmull force-pushed the 1095-add-ability-to-choose-icon-for-manual-triggers branch from d61221a to cc66937 Compare June 19, 2025 09:26
@martmull martmull force-pushed the 1095-add-ability-to-choose-icon-for-manual-triggers branch 2 times, most recently from 63c890a to 92d0ae1 Compare June 19, 2025 13:40
@martmull martmull force-pushed the 1095-add-ability-to-choose-icon-for-manual-triggers branch from 92d0ae1 to 793d439 Compare June 19, 2025 13:55
@martmull martmull force-pushed the 1095-add-ability-to-choose-icon-for-manual-triggers branch from 0ac61b4 to 6d1d4ff Compare June 19, 2025 14:29
@Devessier Devessier self-requested a review June 19, 2025 15:14
Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new icon select looks really clean to me! Let's just confirm the API choice about the description, I don't feel that confident about it.

@martmull martmull enabled auto-merge (squash) June 19, 2025 16:19
Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martmull martmull merged commit 28466ec into main Jun 19, 2025
57 checks passed
@martmull martmull deleted the 1095-add-ability-to-choose-icon-for-manual-triggers branch June 19, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to choose icon for manual triggers
2 participants