Skip to content

Remove workflow feature flag #12732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 19, 2025
Merged

Remove workflow feature flag #12732

merged 4 commits into from
Jun 19, 2025

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Jun 19, 2025

Removing workflows from the lab

greptile-apps[bot]
greptile-apps bot reviewed Jun 19, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes the workflow feature flag across the codebase, transitioning workflows from an experimental lab feature to a core platform capability. Key changes include:

  • Removed IS_WORKFLOW_ENABLED from FeatureFlagKey enum in /packages/twenty-server/src/engine/core-modules/feature-flag/enums/feature-flag-key.enum.ts
  • Simplified DatabaseEventTriggerListener in /packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/database-event-trigger.listener.ts by removing feature flag checks
  • Cleaned up workflow-related feature flag checks from multiple hooks including useObjectMetadataItem and useFilteredObjectMetadataItems
  • Updated mock data and tests to reflect workflow's status as a core feature rather than a lab feature
  • Removed the feature flag validation for workflows from the serverless function resolver

18 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile

packages/twenty-front/src/modules/object-metadata/hooks/useFilteredObjectMetadataItems.ts
Comment on lines 17 to 20
const activeObjectMetadataItems = useMemo(
() =>
objectMetadataItems.filter(
({ isActive, nameSingular }) =>
isActive && !isWorkflowToBeFiltered(nameSingular),
),
[isWorkflowToBeFiltered, objectMetadataItems],
() => objectMetadataItems.filter(({ isActive }) => isActive),
[objectMetadataItems],
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding a comment explaining why we're maintaining two separate filtered lists (activeObjectMetadataItems and activeNonSystemObjectMetadataItems)

martmull
martmull approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025 •
edited
Loading

📊 API Changes Report

GraphQL Schema Changes

GraphQL Schema Changes

[log]
Detected the following changes (1) between schemas:

[log] ✖ Enum value IS_WORKFLOW_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
⚠️ Breaking changes or errors detected in GraphQL schema

[log] 
Detected the following changes (1) between schemas:

[log] ✖  Enum value IS_WORKFLOW_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
Error generating diff

GraphQL Metadata Schema Changes

GraphQL Metadata Schema Changes

[log]
Detected the following changes (1) between schemas:

[log] ✖ Enum value IS_WORKFLOW_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
⚠️ Breaking changes or errors detected in GraphQL metadata schema

[log] 
Detected the following changes (1) between schemas:

[log] ✖  Enum value IS_WORKFLOW_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
Error generating diff

⚠️ Please review these API changes carefully before merging.

⚠️ Breaking Change Protocol

Breaking changes detected but PR title does not contain "breaking" - CI will pass but action needed.

🔄 Options:

  1. If this IS a breaking change: Add "breaking" to your PR title and add BREAKING CHANGE: to your commit message
  2. If this is NOT a breaking change: The API diff tool may have false positives - please review carefully

For breaking changes, add to commit message:

feat: add new API endpoint

BREAKING CHANGE: removed deprecated field from User schema

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025 •
edited
Loading

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:63555

This environment will automatically shut down when the PR is closed or after 5 hours.

@thomtrp thomtrp enabled auto-merge (squash) June 19, 2025 13:14
@thomtrp thomtrp merged commit f9da373 into main Jun 19, 2025
57 checks passed
@thomtrp thomtrp deleted the tt-remove-workflow-feature-flag branch June 19, 2025 13:26
abdulrahmancodes pushed a commit to abdulrahmancodes/twenty that referenced this pull request Jun 19, 2025
@thomtrp @abdulrahmancodes
Remove workflow feature flag (twentyhq#12732)
9468116 
Removing workflows from the lab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@martmull martmull martmull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomtrp @martmull