Fixed record picker loading flickering #12736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Extensive refactoring of record picker components to eliminate loading state flickering through sophisticated state management.
- Introduced new debounced loading states with
MultipleRecordPickerLoadingEffectandSingleRecordPickerLoadingEffectusing 100ms for initial and 350ms for subsequent loads - Added
CSSWidthtype andRecordPickerLoadingSkeletonListwith varying widths for more natural loading animations - Implemented granular loading states (initial, skeleton, fetch-more) using new component states for better visual transitions
- Removed direct Recoil state management from display components, delegating to dedicated loading effect components
- Made intersection observer height 0px in
MultipleRecordPickerFetchMoreLoaderto prevent layout shifts
17 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
...ages/twenty-front/src/modules/ui/layout/dropdown/components/__stories__/Dropdown.stories.tsx
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:51119 This environment will automatically shut down when the PR is closed or after 5 hours. |
Comment on lines
+111
to
+114
| onEnter={() => { | ||
| setSelectedRecordId(undefined); | ||
| onRecordSelected(); | ||
| }} |
There was a problem hiding this comment.
Where possible it's best to create named functions to avoid un-necessary creation of anonymous functions on re-renders.
function onEnter(){
setSelectedRecordId(undefined);
onRecordSelected();
}
...
onEnter={onEnter}| import { SingleRecordPickerComponentInstanceContext } from '@/object-record/record-picker/single-record-picker/states/contexts/SingleRecordPickerComponentInstanceContext'; | ||
| import { createComponentStateV2 } from '@/ui/utilities/state/component-state/utils/createComponentStateV2'; | ||
|
|
||
| export const singleRecordPickerShowSkeletonComponentState = |
There was a problem hiding this comment.
singleRecordPickerShouldShowSkeletonComponentState
charlesBochet
approved these changes
Jun 24, 2025
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
This PR solves a flickering effect on record pickers on the different loading state they can be in. It was designed with @Bonapara to settle on a nice UX feeling. ## Before With fast network (local) : https://github.com/user-attachments/assets/58899934-c705-4b44-b7f6-289045032c11 With slow network : https://github.com/user-attachments/assets/9fb18d86-9da6-4e5d-a83f-00c810fab2dc ## After https://github.com/user-attachments/assets/f4abb40f-5d42-4c46-88ab-aaef4f883f7f Fixes twentyhq#12680 --------- Co-authored-by: Charles Bochet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a flickering effect on record pickers on the different loading state they can be in.
It was designed with @Bonapara to settle on a nice UX feeling.
Before
With fast network (local) :
Before.fast.mov
With slow network :
Before.slow.mov
After
After.mov
Fixes #12680