Prevent workflows to be opened in side panel #12738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added functionality to prevent workflow-related views from being opened in side panels, with two key implementation changes:
- Enhanced
useCreateViewFromCurrentViewhook to preserve theopenRecordInsetting when creating new views from existing ones - Modified
ObjectOptionsDropdownLayoutOpenInContentto disable side panel option for workflow and version objects
These changes address the UX issue where workflow views were incorrectly defaulting to side panel display.
2 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
...bject-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutOpenInContent.tsx
Outdated
Show resolved
Hide resolved
...bject-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutOpenInContent.tsx
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:17760 This environment will automatically shut down when the PR is closed or after 5 hours. |
martmull
reviewed
Jun 19, 2025
thomtrp
force-pushed
the
tt-block-side-panel-for-workflow-and-version
branch
from
b9c0ab2 to
93cad9f
Compare
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 19, 2025
Workflow views and versions are seed being opened by default into record page. Issue is that: - new views are set by default to side panel. Updated by copying the current opensIn value to the new view - users can still select side panel into their options. Disabling the button. <img width="650" alt="Capture d’écran 2025-06-19 à 16 15 34" src="https://github.com/user-attachments/assets/0ddc3284-0fed-404f-9c1d-225c65549fd1" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow views and versions are seed being opened by default into record page. Issue is that: