Protect serverless migration metadata operations interacting with metadata #12739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced defensive handling in database migration to safely move enum types from 'metadata' to 'core' schema, specifically preventing errors during serverlessFunction table modifications.
- Added existence check before moving each enum type from 'metadata' schema to prevent errors with non-existent types
- Improved schema migration reliability by handling each enum type separately instead of bulk ALTER TYPE operations
- Modified handling of 'syncStatus' enum removal from serverlessFunction table to prevent migration failures
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:28314 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
approved these changes
Jun 19, 2025
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 19, 2025
…adata (twentyhq#12739) # Introduction This migration has been introduced in 0.54 we should determine how we wanna handle retro-compatibility with this, might not wanna merge this one latest main 🤔 but only a new 0.54 patch related to twentyhq#12651 (comment) ## Concerns If a workspace fails this migration that's not a good sign, the metadata schema should be completely empty since 0.54 `metadata` merge into `core` migration. Please review you existing entries in the schema and verify they exists in the dest `core` one
prastoin
added a commit
that referenced
this pull request
Jun 19, 2025
…adata (#12739) # Introduction This migration has been introduced in 0.54 we should determine how we wanna handle retro-compatibility with this, might not wanna merge this one latest main 🤔 but only a new 0.54 patch related to #12651 (comment) ## Concerns If a workspace fails this migration that's not a good sign, the metadata schema should be completely empty since 0.54 `metadata` merge into `core` migration. Please review you existing entries in the schema and verify they exists in the dest `core` one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This migration has been introduced in 0.54 we should determine how we wanna handle retro-compatibility with this, might not wanna merge this one latest main 🤔 but only a new 0.54 patch
related to #12651 (comment)
Concerns
If a workspace fails this migration that's not a good sign, the metadata schema should be completely empty since 0.54
metadatamerge intocoremigration.Please review you existing entries in the schema and verify they exists in the dest
coreoneOr maybe the schema just exists, empty, just like a shell because we didnot drop it yeat :p