Remove url checking in workflow run #12743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removes URL validation from HTTP request workflow action schema, shifting validation from schema-level to runtime execution phase.
- Removed URL validation constraint from
workflowSchema.tsto prevent workflow interruption on invalid URLs - Change aligns with existing pattern where action validation occurs during execution rather than schema validation
- Note: This could potentially lead to more runtime errors that would have previously been caught during schema validation
- Shifts to a more permissive schema approach, matching other action schemas in the codebase
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
martmull
force-pushed
the
1112-bug-http-request-breaks-workflow-run-when-failing
branch
from
ecf22e8 to
38adf3c
Compare
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:63757 This environment will automatically shut down when the PR is closed or after 5 hours. |
thomtrp
approved these changes
Jun 19, 2025
martmull
deleted the
1112-bug-http-request-breaks-workflow-run-when-failing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After