UpdateServerless migration fix 2 #12755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Migration refactoring to improve PostgreSQL compatibility by changing enum type existence check from information_schema.types to pg_type table querying in serverless function column removal.
- Changed type existence check query in
1748942397538-removeUselessServerlessFunctionColumn.tsto usepg_typeinstead ofinformation_schema.typesfor better PostgreSQL compliance - Affects how the migration handles the
ServerlessFunctionSyncStatusenum type during column removal - Consider adding a test case to verify proper enum cleanup across different PostgreSQL versions
- Query pattern should be consistent with the one used in
1702479005171-addSubscriptionStatusOnWorkspace.ts
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
guillim
approved these changes
Jun 20, 2025
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:4949 This environment will automatically shut down when the PR is closed or after 5 hours. |
prastoin
added a commit
that referenced
this pull request
Jun 20, 2025
ijreilly
pushed a commit
that referenced
this pull request
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12651 (comment)