Skip to content

Refactor sync metadata to handle index creation if already exists #12757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2025
Merged

Refactor sync metadata to handle index creation if already exists #12757

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f874b7
temporary code
guillim Jun 20, 2025
6b5d89a
changing the way we check errors
guillim Jun 20, 2025
36d36cf
adding toto
guillim Jun 20, 2025
d0a1ba5
better way
guillim Jun 20, 2025
a170cc6
Merge branch 'main' into temproary-index-code
guillim Jun 20, 2025
51ab7b4
typo
guillim Jun 20, 2025
319a7e1
Merge branch 'temproary-index-code' of https://github.com/twentyhq/tw…
guillim Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions ...engine/workspace-manager/workspace-migration-runner/workspace-migration-runner.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Injectable, Logger } from '@nestjs/common';

import { isDefined } from 'twenty-shared/utils';
import { QueryRunner, Table, TableColumn, TableIndex } from 'typeorm';
import { QueryRunner, Table, TableColumn } from 'typeorm';

import { IndexType } from 'src/engine/metadata-modules/index-metadata/index-metadata.entity';
import {
Expand Down Expand Up @@ -208,18 +208,16 @@ export class WorkspaceMigrationRunnerService {
const quotedColumns = index.columns.map((column) => `"${column}"`);

await queryRunner.query(`
CREATE INDEX "${index.name}" ON "${schemaName}"."${tableName}" USING ${index.type} (${quotedColumns.join(', ')})
CREATE INDEX IF NOT EXISTS "${index.name}" ON "${schemaName}"."${tableName}" USING ${index.type} (${quotedColumns.join(', ')})
`);
} else {
await queryRunner.createIndex(
`${schemaName}.${tableName}`,
new TableIndex({
name: index.name,
columnNames: index.columns,
isUnique: index.isUnique,
where: index.where ?? undefined,
}),
);
const quotedColumns = index.columns.map((column) => `"${column}"`);
const isUnique = index.isUnique ? 'UNIQUE' : '';
const whereClause = index.where ? `WHERE ${index.where}` : '';

await queryRunner.query(`
CREATE ${isUnique} INDEX IF NOT EXISTS "${index.name}" ON "${schemaName}"."${tableName}" (${quotedColumns.join(', ')}) ${whereClause}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Would still escape params here

`);
}
} catch (error) {
// Ignore error if index already exists
Expand Down
Loading