fix confirm close dialog + add restart confirm dialog #12761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:63338 This environment will automatically shut down when the PR is closed or after 5 hours. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced modal dialog interactions in the spreadsheet import flow with improved UX safeguards and clearer user guidance.
- Added confirmation dialog for restarting import in
MatchColumnsStep, preventing accidental data loss with 'Restart Import' button replacing 'Back' - Implemented
shouldCloseModalOnClickOutsideOrEscapeprop in Modal component to prevent accidental closures - Simplified
SpreadSheetImportModalCloseButtoninto a pure presentational component, moving dialog logic to parent - Added step-aware confirmation dialogs in
SpreadsheetImportcomponent, auto-closing only after import completion - Made
onCloseprop required inSpreadSheetImportModalWrapperwith mobile viewport responsiveness
5 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
239
to
242
| const handleClose = () => { | ||
| onClose?.(); | ||
| closeModal(modalId); | ||
| if (shouldCloseModalOnClickOutsideOrEscape) closeModal(modalId); | ||
| }; |
There was a problem hiding this comment.
logic: handleClose might execute onClose even when shouldCloseModalOnClickOutsideOrEscape is false, which could be unexpected. Consider moving the onClose call inside the if condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
closes : twentyhq/core-team-issues#1071