-
Notifications
You must be signed in to change notification settings - Fork 3.6k
i18n - translations #12764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n - translations #12764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Large-scale internationalization update across the Twenty application, adding and updating translations for 30+ languages including German, Finnish, Arabic, Korean, Russian, and more.
- Comprehensive update of role-based permissions and object-level access translations across all languages
- Addition of new billing and subscription-related translations in multiple locales
- Migration of deprecated translations (marked with #~) to new message IDs across language files
- Generated TypeScript files (.ts) from updated PO files using the Lingui framework for all supported languages
- Standardization of terminology around workspace management and user permissions across all translations
62 files reviewed, 14 comments
Edit PR Review Bot Settings | Greptile
#. js-lingui-id: OeIgEg | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can {humanReadableAction} {objectLabel} records" | ||
msgstr "" | ||
|
||
#. js-lingui-id: D0C09b | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can't {humanReadableAction} {objectLabel} records" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Critical role permission strings left untranslated. These need Hebrew translations for security-related UI elements to work properly.
#. js-lingui-id: 9MxZtA | ||
#: src/modules/settings/roles/role-permissions/objects-permissions/components/SettingsRolePermissionsObjectsSection.tsx | ||
msgid "Actions you can perform on all objects" | ||
msgid "Actions users can perform on all objects" | ||
msgstr "" | ||
|
||
#. js-lingui-id: xnXGwA | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelSection.tsx | ||
msgid "Actions users can perform on specific objects" | ||
msgstr "" | ||
|
||
#. js-lingui-id: N4ZcCd | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/object-form/components/SettingsRolePermissionsObjectLevelObjectFormObjectLevel.tsx | ||
msgid "Actions users can perform on this object" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing translations for several new user action strings related to permissions. These need to be translated to maintain consistency in the Spanish interface
|
||
#. js-lingui-id: 17M/rH | ||
#: src/modules/settings/roles/components/SettingsRolesList.tsx | ||
msgid "Assign roles to manage each member’s access and permissions" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider keeping role-related terminology consistent throughout translations. 'Assign roles to manage' vs 'Asignar funciones para especificar'
msgid "All lines" | ||
msgstr "Todas as linhas" | ||
|
||
#. js-lingui-id: zIk4M6 | ||
#: src/modules/settings/roles/role-permissions/objects-permissions/components/SettingsRolePermissionsObjectsSection.tsx | ||
msgid "All objects" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: New permission strings lack translations (msgstr
values are empty). These should be translated before merging
#. js-lingui-id: OeIgEg | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can {humanReadableAction} {objectLabel} records" | ||
msgstr "" | ||
|
||
#. js-lingui-id: D0C09b | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can't {humanReadableAction} {objectLabel} records" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: New permission-related strings added without translations. These should be translated to Catalan before merging.
msgid "All lines" | ||
msgstr "Všechny řádky" | ||
|
||
#. js-lingui-id: zIk4M6 | ||
#: src/modules/settings/roles/role-permissions/objects-permissions/components/SettingsRolePermissionsObjectsSection.tsx | ||
msgid "All objects" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding translation for 'All objects' as it's a commonly used UI element
msgid "{name}" | ||
msgstr "{name}" | ||
|
||
#. js-lingui-id: OeIgEg | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can {humanReadableAction} {objectLabel} records" | ||
msgstr "" | ||
|
||
#. js-lingui-id: D0C09b | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can't {humanReadableAction} {objectLabel} records" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: New messages are added but their translations are empty (msgstr ""). These should be translated before merging.
#. js-lingui-id: OeIgEg | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can {humanReadableAction} {objectLabel} records" | ||
msgstr "" | ||
|
||
#. js-lingui-id: D0C09b | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can't {humanReadableAction} {objectLabel} records" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing translations for new role permission strings. These strings are important for user interface feedback and should not be left empty.
|
||
#. js-lingui-id: OeIgEg | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can {humanReadableAction} {objectLabel} records" | ||
msgstr "" | ||
|
||
#. js-lingui-id: D0C09b | ||
#: src/modules/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelOverrideCell.tsx | ||
msgid "{roleLabel} can't {humanReadableAction} {objectLabel} records" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Dutch translations for new role permissions messages. These strings should be translated as they are user-facing content.
#: src/modules/settings/roles/role-permissions/objects-permissions/components/SettingsRolePermissionsObjectsSection.tsx | ||
msgid "All objects" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider translating 'All objects' to 'Alle objecten' to maintain consistency with other Dutch translations
#: src/modules/settings/roles/role-permissions/objects-permissions/components/SettingsRolePermissionsObjectsSection.tsx | |
msgid "All objects" | |
msgstr "" | |
#: src/modules/settings/roles/role-permissions/objects-permissions/components/SettingsRolePermissionsObjectsSection.tsx | |
msgid "All objects" | |
msgstr "Alle objecten" |
Log
|
Created by Github action --------- Co-authored-by: github-actions <[email protected]>
Created by Github action