Skip to content

i18n - translations #12767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

i18n - translations #12767

merged 2 commits into from
Jun 20, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Extensive internationalization (i18n) update across multiple language files, adding new translations for spreadsheet import functionality and fixing file paths.

  • Updated all locale files to reflect component path changes from SpreadSheetImportModalCloseButton.tsx to provider/components/SpreadsheetImport.tsx
  • Added new translations for 'Restart', 'Restart Import', and warning message 'You will lose all your mappings' across all language files
  • Generated fresh TypeScript translation files with minified JSON format for all supported languages, maintaining lingui i18n framework compatibility
  • Many newly added strings remain untranslated (empty msgstr) in several languages, particularly for spreadsheet import functionality
  • Code structure follows proper i18n practices with placeholder variables and HTML tags preserved

60 files reviewed, 10 comments
Edit PR Review Bot Settings | Greptile

Comment on lines 4460 to +4471
msgid "REST"
msgstr "REST"

#. js-lingui-id: 6z9W13
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart"
msgstr ""

#. js-lingui-id: 82zWno
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart Import"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider translating these new entries for spreadsheet import functionality before merging. Currently empty translations: 'Restart', 'Restart Import', and 'You will lose all your mappings'

Comment on lines 941 to 948
#: src/modules/spreadsheet-import/steps/components/ImportDataStep.tsx
#: src/modules/spreadsheet-import/steps/components/ValidationStep/ValidationStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/components/SpreadSheetImportModalCloseButton.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/provider/components/SpreadsheetImport.tsx
#: src/modules/settings/components/SaveAndCancelButtons/CancelButton.tsx
msgid "Cancel"
msgstr "Abbrechen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Duplicate reference to MatchColumnsStep.tsx on consecutive lines. Consider consolidating these import references

Comment on lines 4460 to +4471
msgid "REST"
msgstr "REST"

#. js-lingui-id: 6z9W13
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart"
msgstr ""

#. js-lingui-id: 82zWno
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart Import"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Hebrew translations for several new strings including 'Restart', 'Restart Import', and other spreadsheet import-related text

Comment on lines 933 to +937
#: src/modules/spreadsheet-import/steps/components/ImportDataStep.tsx
#: src/modules/spreadsheet-import/steps/components/ValidationStep/ValidationStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/components/SpreadSheetImportModalCloseButton.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/provider/components/SpreadsheetImport.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider consolidating duplicate Cancel message usage to reduce translation maintenance

Comment on lines 4460 to +4471
msgid "REST"
msgstr "HVILE"

#. js-lingui-id: 6z9W13
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart"
msgstr ""

#. js-lingui-id: 82zWno
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart Import"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing translation for new 'Restart' string that should be 'Start på nytt' in Norwegian

Suggested change
msgid "REST"
msgstr "HVILE"
#. js-lingui-id: 6z9W13
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart"
msgstr ""
#. js-lingui-id: 82zWno
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart Import"
msgstr "Start på nytt"

Comment on lines 4460 to 4474
msgid "REST"
msgstr "ODPOCZYNEK"

#. js-lingui-id: 6z9W13
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart"
msgstr ""

#. js-lingui-id: 82zWno
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart Import"
msgstr ""

#. js-lingui-id: yKu/3Y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: New spreadsheet import translations missing Polish translations (empty msgstr values). These strings should be translated to maintain a consistent user experience

Comment on lines 941 to 947
#: src/modules/spreadsheet-import/steps/components/ImportDataStep.tsx
#: src/modules/spreadsheet-import/steps/components/ValidationStep/ValidationStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/components/SpreadSheetImportModalCloseButton.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/provider/components/SpreadsheetImport.tsx
#: src/modules/settings/components/SaveAndCancelButtons/CancelButton.tsx
msgid "Cancel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Duplicate file path entries for MatchColumnsStep.tsx - should be consolidated to avoid maintenance issues

Comment on lines 4460 to +4472
msgid "REST"
msgstr "REST"

#. js-lingui-id: 6z9W13
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart"
msgstr ""

#. js-lingui-id: 82zWno
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx
msgid "Restart Import"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for new keys 'Restart' and 'Restart Import' related to spreadsheet import functionality

@@ -6081,6 +6093,11 @@ msgstr ""
#~ msgid "You will be charged immediately for the full year."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for 'You will lose all your mappings' which is a critical user-facing message

Comment on lines 732 to 733
msgid "Are you sure? Your current information will not be saved."
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Translation missing for cancel confirmation dialog in spreadsheet import

@FelixMalfait FelixMalfait merged commit 1bdc03f into main Jun 20, 2025
3 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch June 20, 2025 13:38
Copy link
Contributor Author

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5738:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5719:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:4609:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)�[39m
�[90m    at async consumeBody (node:internal/deps/undici/undici:5728:7)�[39m
danger-results://tmp/danger-results-c981b9d9.json

Generated by 🚫 dangerJS against 8c29176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant