-
Notifications
You must be signed in to change notification settings - Fork 3.6k
i18n - translations #12767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n - translations #12767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Extensive internationalization (i18n) update across multiple language files, adding new translations for spreadsheet import functionality and fixing file paths.
- Updated all locale files to reflect component path changes from
SpreadSheetImportModalCloseButton.tsx
toprovider/components/SpreadsheetImport.tsx
- Added new translations for 'Restart', 'Restart Import', and warning message 'You will lose all your mappings' across all language files
- Generated fresh TypeScript translation files with minified JSON format for all supported languages, maintaining lingui i18n framework compatibility
- Many newly added strings remain untranslated (empty
msgstr
) in several languages, particularly for spreadsheet import functionality - Code structure follows proper i18n practices with placeholder variables and HTML tags preserved
60 files reviewed, 10 comments
Edit PR Review Bot Settings | Greptile
msgid "REST" | ||
msgstr "REST" | ||
|
||
#. js-lingui-id: 6z9W13 | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart" | ||
msgstr "" | ||
|
||
#. js-lingui-id: 82zWno | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart Import" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider translating these new entries for spreadsheet import functionality before merging. Currently empty translations: 'Restart', 'Restart Import', and 'You will lose all your mappings'
#: src/modules/spreadsheet-import/steps/components/ImportDataStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/ValidationStep/ValidationStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/components/SpreadSheetImportModalCloseButton.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/provider/components/SpreadsheetImport.tsx | ||
#: src/modules/settings/components/SaveAndCancelButtons/CancelButton.tsx | ||
msgid "Cancel" | ||
msgstr "Abbrechen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Duplicate reference to MatchColumnsStep.tsx on consecutive lines. Consider consolidating these import references
msgid "REST" | ||
msgstr "REST" | ||
|
||
#. js-lingui-id: 6z9W13 | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart" | ||
msgstr "" | ||
|
||
#. js-lingui-id: 82zWno | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart Import" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Hebrew translations for several new strings including 'Restart', 'Restart Import', and other spreadsheet import-related text
#: src/modules/spreadsheet-import/steps/components/ImportDataStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/ValidationStep/ValidationStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/components/SpreadSheetImportModalCloseButton.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/provider/components/SpreadsheetImport.tsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider consolidating duplicate Cancel message usage to reduce translation maintenance
msgid "REST" | ||
msgstr "HVILE" | ||
|
||
#. js-lingui-id: 6z9W13 | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart" | ||
msgstr "" | ||
|
||
#. js-lingui-id: 82zWno | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart Import" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Missing translation for new 'Restart' string that should be 'Start på nytt' in Norwegian
msgid "REST" | |
msgstr "HVILE" | |
#. js-lingui-id: 6z9W13 | |
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | |
msgid "Restart" | |
msgstr "" | |
#. js-lingui-id: 82zWno | |
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | |
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | |
msgid "Restart Import" | |
msgstr "Start på nytt" |
msgid "REST" | ||
msgstr "ODPOCZYNEK" | ||
|
||
#. js-lingui-id: 6z9W13 | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart" | ||
msgstr "" | ||
|
||
#. js-lingui-id: 82zWno | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart Import" | ||
msgstr "" | ||
|
||
#. js-lingui-id: yKu/3Y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: New spreadsheet import translations missing Polish translations (empty msgstr values). These strings should be translated to maintain a consistent user experience
#: src/modules/spreadsheet-import/steps/components/ImportDataStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/ValidationStep/ValidationStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/components/SpreadSheetImportModalCloseButton.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/provider/components/SpreadsheetImport.tsx | ||
#: src/modules/settings/components/SaveAndCancelButtons/CancelButton.tsx | ||
msgid "Cancel" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Duplicate file path entries for MatchColumnsStep.tsx - should be consolidated to avoid maintenance issues
msgid "REST" | ||
msgstr "REST" | ||
|
||
#. js-lingui-id: 6z9W13 | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart" | ||
msgstr "" | ||
|
||
#. js-lingui-id: 82zWno | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
#: src/modules/spreadsheet-import/steps/components/MatchColumnsStep/MatchColumnsStep.tsx | ||
msgid "Restart Import" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing translation for new keys 'Restart' and 'Restart Import' related to spreadsheet import functionality
@@ -6081,6 +6093,11 @@ msgstr "" | |||
#~ msgid "You will be charged immediately for the full year." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing translation for 'You will lose all your mappings' which is a critical user-facing message
msgid "Are you sure? Your current information will not be saved." | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Translation missing for cancel confirmation dialog in spreadsheet import
Log
|
Created by Github action