Hide tab system for pending form nodes #12769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improved form node UX by simplifying the workflow visualization interface, hiding the tab system for pending form nodes while displaying it for completed ones.
- Added
getShouldFocusNodeTab.tsutility to determine when to focus the node tab based on execution status and node type - Modified
CommandMenuWorkflowRunViewStepContent.tsxto conditionally render either a focused node view or full tab interface - Streamlined UI by removing unnecessary tabs when a form node is pending user input
- Maintains full tab system (Output/Node/Input) visibility for completed form nodes for better context
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:18820 This environment will automatically shut down when the PR is closed or after 5 hours. |
thomtrp
reviewed
Jun 20, 2025
| isFormNode, | ||
| }: { | ||
| stepExecutionStatus: WorkflowDiagramRunStatus; | ||
| isFormNode: boolean; |
There was a problem hiding this comment.
I like that this function is generic but the input is not. I would go with actionType rather than isFormNode
thomtrp
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.