Fix export to pdf #12782
Merged
Fix export to pdf #12782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed PDF export functionality by implementing proper font registration for the Inter font family in BlockNote editor exports.
- Added singleton pattern in
packages/twenty-front/src/modules/action-menu/actions/record-actions/single-record/utils/exportBlockNoteEditorToPdf.tsto ensure Inter font is registered only once - Resolved font loading issues that were causing PDF export failures
- Change aligns with existing font usage in email templates and Storybook preview
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
Sentry Issue: TWENTY-FRONT-4ET |
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:20321 This environment will automatically shut down when the PR is closed or after 5 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export to PDF was throwing an error due to fonts not being registered. Maybe linked to the async loading changes or blocknote upgrades.
I wasn't a fan of hardcoding the fonts here (makes a second source of truth for Inter), but after a few tests this seemed like the best compromise