Fix e2e tests #12783
Merged
Fix e2e tests #12783
+17
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updates E2E workflow tests to improve reliability and match current UI text content in packages/twenty-e2e-testing/tests/workflow-run.spec.ts.
- Fixed test assertions to match updated UI text by changing 'record(s)' to 'record'
- Added required 'Add Field' step during form creation workflow
- Improved node selection reliability by using command menu locator context
- Increased form step verification timeout to 30 seconds for better test stability
- Streamlined test flow by removing redundant workflow list view navigation
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
93
to
95
| const addFormFieldButton = page.getByText('Add Field', { exact: true }) | ||
|
|
||
| await addFormFieldButton.click(); |
There was a problem hiding this comment.
style: Add semicolon after addFormFieldButton declaration to maintain consistency with codebase style
Suggested change
| const addFormFieldButton = page.getByText('Add Field', { exact: true }) | |
| await addFormFieldButton.click(); | |
| const addFormFieldButton = page.getByText('Add Field', { exact: true }); |
Devessier
commented
Jun 23, 2025
Comment on lines
+103
to
+105
| { | ||
| timeout: 30_000, | ||
| }, |
There was a problem hiding this comment.
Workers' updates can take time to arrive.
thomtrp
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: