Record filter greaterThan becomes inclusive as lowerThan

[prastoin]

Introduction

Greater than filtering wasn't inclusive whereas lower than was, resulting in sending empty array to filtering resolver

Also refactored the transpilation methods to avoid asserting on the RATING_VALUES order

closes #12779

[greptile-apps]

PR Summary

Modified rating filter behavior in packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownRatingInput.tsx to fix issues with 'greater than' comparisons in the 5-star rating system.

• Changed greater than filter logic to be inclusive (>= instead of >) to prevent errors when filtering 5-star ratings
• Simplified function syntax by converting blocks to single-line arrow functions for better maintainability
• Updated convertGreaterThanRatingToArrayOfRatingValues to ensure proper filtering of maximum rating values

_{1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile}

[prastoin]

@greptileai trigger

[greptile-apps]

PR Summary

Fixed a critical bug in rating filter functionality by changing from array index-based comparison to actual numeric rating values, ensuring accurate filtering behavior.

• Modified convertFieldRatingValueToNumber to extract actual numeric values from rating strings (e.g., '3' from 'RATING_3') instead of using array indices
• Changed comparison logic in convertGreaterThanRatingToArrayOfRatingValues to use actual rating values for more accurate filtering
• Fixed an edge case where rating value 5 wasn't being handled correctly due to zero-based array indexing

_{1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile}

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:25649

This environment will automatically shut down when the PR is closed or after 5 hours.

[prastoin]

@greptileai trigger

[greptile-apps]

PR Summary

Refactored rating value handling by removing dependency on RATING_VALUES array order and implementing more robust type validation and filtering.

• Switched RATING_VALUES from static array to dynamically generated values using Array.from() in record-field/meta-types/constants/RatingValues.ts
• Added new type guard isFieldRatingValue replacing Zod schema with simpler Array.includes() check
• Updated FieldMetadata types to use template literal type (RATING_${number} | null) instead of array-based validation
• Improved spreadsheet validation by extracting rating field validation into dedicated guard function

_{4 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

style: Consider extracting '5' to a named constant like MAX_RATING to make the rating scale more maintainable

[lucasbordeau]

LGTM