Fixes date filter chip bugs #12788
Merged
Fixes date filter chip bugs #12788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improves date filter functionality by refactoring filter chip label computation and operand handling.
- Adds new utility
packages/twenty-front/src/modules/views/utils/getRecordFilterLabelValue.tsto centralize filter label logic - Refactors
useApplyObjectFilterDropdownOperandto properly handle DATE and DATE_TIME filters with IsToday, IsInFuture, IsInPast operands - Extracts complex ternary logic from
EditableFilterChipinto dedicated utility for better maintainability - Fixes crash when selecting relative date filters by properly handling the IsRelative operand case
3 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
...rc/modules/object-record/object-filter-dropdown/hooks/useApplyObjectFilterDropdownOperand.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/components/EditableFilterChip.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/views/utils/getRecordFilterLabelValue.ts
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:37512 This environment will automatically shut down when the PR is closed or after 5 hours. |
bosiraphael
approved these changes
Jun 24, 2025
...rc/modules/object-record/object-filter-dropdown/hooks/useApplyObjectFilterDropdownOperand.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that occurs during filter operand changes.
As a date filter can contain values that have a different shape, mainly date ISO string and hard-coded relative dates, changing the operand without resetting the value to its default was causing a crash.
This PR also extracts the logic that computes the right part of a filter chip into a util instead of a difficult to understand ternary, thus solving small bugs in the value displayed also.
Fixes #12778