[permissions V2] Remove feature flag #12790
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Large-scale feature deployment that removes Permissions V2 feature flag, making it the permanent, default permission system across front and back end.
- Restructures security by making permission validation mandatory in
WorkspaceEntityManagerandRepositorylayers, removing conditional permission checks - Cleans up legacy permission system code, including removal of
UserWorkspaceRoleEntityand deprecated validation methods - Streamlines role management by removing feature flag checks in
RoleServiceand associated components - Reconfigures workspace initialization to always use Permissions V2 system during setup
- Requires attention to deployment planning as this removes backward compatibility with the V1 permission system
22 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| if ( | ||
| standardId && | ||
| [ | ||
| STANDARD_OBJECT_IDS.workflow, | ||
| STANDARD_OBJECT_IDS.workflowRun, | ||
| STANDARD_OBJECT_IDS.workflowVersion, | ||
| ].includes(standardId) | ||
| ) { | ||
| const hasWorkflowsPermissions = this.hasWorkflowsPermissions(role); | ||
|
|
||
| canRead = hasWorkflowsPermissions; | ||
| canUpdate = hasWorkflowsPermissions; | ||
| canSoftDelete = hasWorkflowsPermissions; | ||
| canDestroy = hasWorkflowsPermissions; |
There was a problem hiding this comment.
style: Consider extracting workflow-related standardIds to a constant to improve maintainability
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:7800 This environment will automatically shut down when the PR is closed or after 5 hours. |
📊 API Changes ReportGraphQL Schema ChangesGraphQL Schema Changes[log] [log] ✖ Enum value IS_PERMISSIONS_V2_ENABLED was removed from enum FeatureFlagKey GraphQL Metadata Schema ChangesGraphQL Metadata Schema Changes[log] [log] ✖ Enum value IS_PERMISSIONS_V2_ENABLED was removed from enum FeatureFlagKey
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues: Did you find this useful? React with a 👍 or 👎 |
No description provided.