Fix rating field default value #12792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Changed default rating field behavior by removing the default 'RATING_1' value in packages/twenty-front/src/modules/object-record/record-field/meta-types/hooks/useRatingFieldDisplay.ts, now defaulting to null instead.
- Modified
useRecordFieldValuehook implementation to include proper generic typing for better type safety - Breaking Change: Changed rating field default from 'RATING_1' to null which may affect components expecting non-null values
- Consider documenting this breaking change and ensuring components handle null rating values gracefully
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:17808 This environment will automatically shut down when the PR is closed or after 5 hours. |
lucasbordeau
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
LGTM
@Bonapara Shouldn't we be able to "clear" a rating field ? So that it is NULL ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12789