-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Permissions][FE] Design followup 5 #12793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Enhanced the workspace member role assignment UI with improved member identification and permission feedback.
- Modified
CurrentWorkspaceMember
type inauth/states/currentWorkspaceMemberState.ts
to includeuserEmail
field for complete member information display - Updated
ForbiddenFieldDisplay.tsx
to show user-friendly 'Not shared' with lock icon instead of technical 'Forbidden' text - Added workspace member full name and email display in role assignment picker with fixed 320px width for consistent formatting
- Enhanced
MenuItemAvatar.tsx
to support contextual text display, improving member identification in dropdowns - Improved role assignment UI organization by using
MenuItemLeftContent
for consistent layout across components
5 files reviewed, 5 comments
Edit PR Review Bot Settings | Greptile
packages/twenty-ui/src/navigation/menu-item/components/MenuItemAvatar.tsx
Outdated
Show resolved
Hide resolved
...ngs/roles/role-assignment/components/SettingsRoleAssignmentWorkspaceMemberPickerDropdown.tsx
Outdated
Show resolved
Hide resolved
...es/role-assignment/components/SettingsRoleAssignmentWorkspaceMemberPickerDropdownContent.tsx
Outdated
Show resolved
Hide resolved
...es/role-assignment/components/SettingsRoleAssignmentWorkspaceMemberPickerDropdownContent.tsx
Outdated
Show resolved
Hide resolved
...es/role-assignment/components/SettingsRoleAssignmentWorkspaceMemberPickerDropdownContent.tsx
Outdated
Show resolved
Hide resolved
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:40896 This environment will automatically shut down when the PR is closed or after 5 hours. |
...s/twenty-server/src/engine/core-modules/user/services/workspace-member-transpiler.service.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job !
...ngs/roles/role-assignment/components/SettingsRoleAssignmentWorkspaceMemberPickerDropdown.tsx
Outdated
Show resolved
Hide resolved
@@ -293,7 +293,9 @@ const StyledButton = styled('button', { | |||
}` | |||
: 'none'}; | |||
color: ${!inverted | |||
? theme.font.color.danger | |||
? !disabled | |||
? theme.font.color.danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: Looks very global, I personally can't estimate nor think about other side effects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Although I think it never occurred before that we had button both disabled and with danger accent and the UI didn't match the figma. I'll double check though
📊 API Changes ReportREST API ChangesSummary🔄 Changed Operations (63)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great !
Context