Skip to content

Fix styling inconsistency for FormSingleRecordFieldChip placeholder #12795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

Devessier
Copy link
Contributor

Before

CleanShot 2025-06-23 at 17 01 16@2x

After

CleanShot 2025-06-23 at 17 01 01@2x

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Standardizes form field placeholder styling across the application by introducing a centralized FormFieldPlaceholder component and associated styles.

  • Added new FormFieldPlaceholder.tsx component and FORM_FIELD_PLACEHOLDER_STYLES constant to ensure consistent placeholder appearance
  • Refactored FormSingleRecordFieldChip to use the new placeholder component, improving visual consistency as shown in screenshots
  • Updated TextVariableEditor and FormMultiSelectFieldInput to use the shared placeholder styling
  • Modified WorkflowEditActionFormBuilder to replace custom styled div with reusable FormFieldPlaceholder

6 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@lucasbordeau lucasbordeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create a component for StyledPlaceholder ?

Also could margin be replaced by a padding or a gap ?

@Devessier
Copy link
Contributor Author

@lucasbordeau, I created the FormFieldPlaceholder reusable component in my PR. I overrode the component in some places to keep specific local styles, like width: 100% and margin: ${({ theme }) => theme.spacing(2)};.

I will change margin to padding.

Copy link
Contributor

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:30411

This environment will automatically shut down when the PR is closed or after 5 hours.

@Devessier
Copy link
Contributor Author

@lucasbordeau, I tried to switch from margin to padding, but that's not a drop-in replacement. I prefer to refactor the code later. It could easily break many subtle details in the workflows.

@Devessier Devessier merged commit d99bff9 into main Jun 23, 2025
55 of 57 checks passed
@Devessier Devessier deleted the fix-form-fields-placeholder-inconsistencies branch June 23, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants