-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Generate id for standard multi select field options #12799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added MULTI_SELECT field type support to ensure proper UUID generation for field options, primarily impacting workflow status filtering.
- Updated
prepareFieldMetadataForCreation
inworkspace-metadata-updater.service.ts
to handle MULTI_SELECT fields similarly to SELECT fields - Modified workflow status definitions in
workflow.workspace-entity.ts
with proper MULTI_SELECT type configuration - Fixed workflow status filtering by ensuring UUIDs are consistently generated for status options
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
@@ -114,7 +114,9 @@ export class WorkspaceMetadataUpdaterService { | |||
private prepareFieldMetadataForCreation(field: PartialFieldMetadata) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider removing TODO comment since the implementation looks complete and clear
📊 API Changes ReportREST API ChangesSummary🔄 Changed Operations (63)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me!
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:30216 This environment will automatically shut down when the PR is closed or after 5 hours. |
Fixes #12723
After
Enregistrement.de.l.ecran.2025-06-23.a.18.27.28.mov