-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add position / positions to reserved keywords #12800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added 'position' and 'positions' to reserved keywords list to prevent metadata naming conflicts, particularly important given its usage in standard objects like Person and Favorite for ordering.
- Added protection against using 'position' as a metadata name, which is crucial since it's already used as a core field in
PersonObjectMetadata
andFavoriteObjectMetadata
for ordering functionality - Change helps prevent potential schema conflicts in object metadata definitions where 'position' has special significance
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
📊 API Changes ReportREST API ChangesSummary🔄 Changed Operations (63)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:36680 This environment will automatically shut down when the PR is closed or after 5 hours. |
No description provided.