[Messaging logs] Better logging AggregateError #12801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced error logging for AggregateError instances in token refresh operations to improve debugging capabilities.
- Added detailed AggregateError logging in
packages/twenty-server/src/modules/connected-account/refresh-tokens-manager/services/connected-account-refresh-tokens.service.tsto capture error message, name, and individual errors array - Improved error traceability for issue #12589 by providing granular error information in catch blocks
- Maintained existing error handling logic while adding better visibility into token refresh failures
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| this.logger.log(error?.errors); | ||
| } else { | ||
| this.logger.log(error); | ||
| } | ||
| throw new ConnectedAccountRefreshAccessTokenException( | ||
| `Error refreshing tokens for connected account ${connectedAccount.id.slice(0, 7)} in workspace ${workspaceId.slice(0, 7)}: ${error.message} ${error?.response?.data?.error_description}`, |
There was a problem hiding this comment.
style: Consider including error.errors in the exception message for AggregateError to preserve the detailed error information
guillim
changed the title
guillim
changed the title
📊 API Changes ReportREST API ChangesSummary🔄 Changed Operations (63)
|
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:40852 This environment will automatically shut down when the PR is closed or after 5 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"An AggregateError in NestJS usually indicates that multiple errors were thrown or collected together and then re-thrown as a single error."
Since we have this in logs, we cannot debug properly the error #12589
That is why we will better log this errors in order to tackle them ASAP
Note: sentry errors match our Grafan logs agggregate errors as you can see