-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[permissions V2] Fix - filter objects to search #12803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added permission checks to the multiple record picker search to ensure users can only search for records they have read access to.
- Modified
useMultipleRecordPickerPerformSearch
hook to filter searchable objects usinguseObjectPermissions
hook before search execution - Change aligns with existing permission system by preventing unauthorized access to object records in search results
- Implements proper permission boundary at the UI level rather than relying solely on backend checks
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the global search as well? @ijreilly Thank you!
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:46960 This environment will automatically shut down when the PR is closed or after 5 hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
In morph relation pickers, we were not taking into account permissions when computing the list of objects to search for, while we should not search for objects we don't have read permissions on (permission denied error)