Skip to content

i18n - translations #12804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

i18n - translations #12804

merged 1 commit into from
Jun 23, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

@FelixMalfait FelixMalfait merged commit 37b48e2 into main Jun 23, 2025
2 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch June 23, 2025 17:20
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Comprehensive internationalization update across all language files (.po) in twenty-front/src/locales, transitioning from 'Forbidden' to 'Not shared' messaging in field displays.

  • Deprecated 'Forbidden' translations across 27 language files including en.po, fr-FR.po, zh-CN.po by marking with #~ prefix
  • Added source reference to ForbiddenFieldDisplay.tsx for 'Not shared' message ID (51G4/+) in all language files
  • All changes follow proper .po file formatting with consistent message deprecation syntax
  • Updated user-facing error messages to be more friendly by replacing technical 'Forbidden' with descriptive 'Not shared'

29 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile

Comment on lines 3929 to 3931
msgstr "Ikke fundet"

#. js-lingui-id: 51G4/+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Danish translation for 'Not shared' string which is used in two components. This should be translated to maintain consistent localization

Suggested change
msgstr "Ikke fundet"
#. js-lingui-id: 51G4/+
msgstr "Ikke delt"

Comment on lines 3929 to 3935
msgstr "Não encontrado"

#. js-lingui-id: 51G4/+
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
#: src/modules/activities/calendar/components/CalendarEventNotSharedContent.tsx
msgid "Not shared"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for 'Not shared' message ID which is now used in multiple components

Suggested change
msgstr "Não encontrado"
#. js-lingui-id: 51G4/+
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
#: src/modules/activities/calendar/components/CalendarEventNotSharedContent.tsx
msgid "Not shared"
msgstr ""
msgstr "Não encontrado"
#. js-lingui-id: 51G4/+
#: src/modules/object-record/record-field/meta-types/display/components/ForbiddenFieldDisplay.tsx
#: src/modules/activities/calendar/components/CalendarEventNotSharedContent.tsx
msgid "Not shared"
msgstr "Não partilhado"

Copy link
Contributor Author

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5738:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5719:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:4609:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)�[39m
�[90m    at async consumeBody (node:internal/deps/undici/undici:5728:7)�[39m
danger-results://tmp/danger-results-536bcd98.json

Generated by 🚫 dangerJS against 188117d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant