Fix CombinedFindManyRecords with permissions #12805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed permission handling in CombinedFindManyRecords to properly filter root-level objects in addition to relations, particularly affecting data model views using multiple object queries.
- Modified
useGenerateCombinedFindManyRecordsQueryto filter operation signatures based on user permissions before query generation - Improved query generation flow by moving parameter handling after permission checks
- Fixed potential unauthorized access issues in pages using CombinedFindManyRecords for multiple object queries
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
.../src/modules/object-record/multiple-objects/hooks/useGenerateCombinedFindManyRecordsQuery.ts
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:41169 This environment will automatically shut down when the PR is closed or after 5 hours. |
charlesBochet
approved these changes
Jun 23, 2025
charlesBochet
deleted the
c--fix-combined-find-many-records-with-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This was already for relations but not the root object. This caused issues with pages where we query multiple objects with the CombinedFindManyRecords such as the data model
In the example below, we don't have access to rockets so we don't see the real number of instances (now displays 0) and the FE shouldn't query it.
Diff
