Skip to content

i18n - translations #12807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

i18n - translations #12807

merged 2 commits into from
Jun 23, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Major localization update adding new translation strings and generated TypeScript files across multiple languages, with a focus on workspace creation flow messaging.

  • Added untranslated strings 'Creating your schema', 'Prefilling your workspace data', and 'Setting up your database' to all .po files for workspace creation flow
  • Generated corresponding .ts files for 25+ languages using @lingui/core Messages type format
  • Left several new technical strings untranslated across multiple languages, particularly for database and configuration settings
  • All generated files maintain proper JSON structure with minified formatting for production use
  • Updated metadata headers and plural form rules for newer language files like ar-SA and sr-Cyrl

59 files reviewed, 6 comments
Edit PR Review Bot Settings | Greptile

Comment on lines 1485 to 1495
#~ msgid "Created"
#~ msgstr "Vytvořeno"

#. js-lingui-id: TlL0Pl
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your schema"
msgstr ""

#. js-lingui-id: R3PLzn
#: src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownCurrencySelect.tsx
msgid "currencies"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Czech translation for 'Creating your schema', 'Prefilling your workspace data', and 'Setting up your database'. These strings are critical for user communication during workspace setup.

Comment on lines 1485 to +1491
#~ msgid "Created"
#~ msgstr "Criado"

#. js-lingui-id: TlL0Pl
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your schema"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Empty translation string for 'Creating your schema' needs to be filled with proper Portuguese translation

Suggested change
#~ msgid "Created"
#~ msgstr "Criado"
#. js-lingui-id: TlL0Pl
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your schema"
msgstr ""
#~ msgid "Created"
#~ msgstr "Criado"
#. js-lingui-id: TlL0Pl
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your schema"
msgstr "Criando seu esquema"

Comment on lines 4315 to +4321
#~ msgid "Portuguese (Portugal)"
#~ msgstr "Portuguese (Portugal)"

#. js-lingui-id: /IZFIg
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Prefilling your workspace data"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Empty translation string for 'Prefilling your workspace data' needs to be filled with proper Portuguese translation

Suggested change
#~ msgid "Portuguese (Portugal)"
#~ msgstr "Portuguese (Portugal)"
#. js-lingui-id: /IZFIg
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Prefilling your workspace data"
msgstr ""
#~ msgid "Portuguese (Portugal)"
#~ msgstr "Portuguese (Portugal)"
#. js-lingui-id: /IZFIg
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Prefilling your workspace data"
msgstr "Preenchendo os dados do seu workspace"

Comment on lines 5005 to +5011
msgid "Set the name of your subdomain"
msgstr "Defina o nome do seu subdomínio"

#. js-lingui-id: oG3fDz
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Setting up your database"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Empty translation string for 'Setting up your database' needs to be filled with proper Portuguese translation

Suggested change
msgid "Set the name of your subdomain"
msgstr "Defina o nome do seu subdomínio"
#. js-lingui-id: oG3fDz
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Setting up your database"
msgstr ""
msgid "Set the name of your subdomain"
msgstr "Defina o nome do seu subdomínio"
#. js-lingui-id: oG3fDz
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Setting up your database"
msgstr "Configurando seu banco de dados"

Comment on lines 5007 to +5010

#. js-lingui-id: oG3fDz
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Setting up your database"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing translation for 'Setting up your database'. Critical onboarding message needs translation.

Comment on lines +1489 to +1491
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your schema"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for 'Creating your schema' string which is needed for the onboarding flow

Suggested change
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your schema"
msgstr ""
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your schema"
msgstr "Crearea schemei tale"

@FelixMalfait FelixMalfait merged commit 6651aba into main Jun 23, 2025
3 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch June 23, 2025 21:33
Copy link
Contributor Author

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5738:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5719:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:4609:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)�[39m
�[90m    at async consumeBody (node:internal/deps/undici/undici:5728:7)�[39m
danger-results://tmp/danger-results-81121e0c.json

Generated by 🚫 dangerJS against a2e62cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant