Skip to content

i18n - translations #12809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

i18n - translations #12809

merged 2 commits into from
Jun 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Large-scale internationalization update adding new currency format settings translations across multiple language files, with a focus on SettingsDataModelFieldCurrencyForm component strings.

  • Added new translation strings 'Choose between Short and Full' and 'Format' across all language .po files
  • Added generated TypeScript files (*.ts) in packages/twenty-front/src/locales/generated/ for all supported languages with minified JSON translations
  • Several languages including cs-CZ, af-ZA, pl-PL have untranslated strings (empty msgstr fields) that need translation
  • Missing Hungarian translations in packages/twenty-front/src/locales/hu-HU.po should be addressed for currency format settings

61 files reviewed, 14 comments
Edit PR Review Bot Settings | Greptile

Comment on lines +1072 to +1074
#. js-lingui-id: 2ZFG9X
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose between Short and Full"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The new string 'Choose between Short and Full' is missing its French translation. This needs to be translated to maintain full localization coverage.

Comment on lines +1072 to +1076
#. js-lingui-id: 2ZFG9X
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose between Short and Full"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Hungarian translation for 'Choose between Short and Full' string. This will cause English text to appear in a Hungarian UI context.

Comment on lines 1069 to 1079
msgid "Choose between OIDC and SAML protocols"
msgstr "Kies tussen OIDC en SAML protokolle"

#. js-lingui-id: 2ZFG9X
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose between Short and Full"
msgstr ""

#. js-lingui-id: YcrXB2
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose the default currency that will apply"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translations for two new strings: 'Choose between Short and Full' and 'Format'. These need to be translated to maintain full Afrikaans language support.

Comment on lines +2613 to +2617
#. js-lingui-id: kI1qVD
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Format"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Hungarian translation for 'Format' string. This will cause English text to appear in a Hungarian UI context.

Comment on lines +1072 to +1075
#. js-lingui-id: 2ZFG9X
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose between Short and Full"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing Danish translation for 'Choose between Short and Full'. This should be translated to maintain consistency across the UI.

Comment on lines 1069 to 1079
msgid "Choose between OIDC and SAML protocols"
msgstr "Valitse OIDC- ja SAML-protokollien välillä"

#. js-lingui-id: 2ZFG9X
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose between Short and Full"
msgstr ""

#. js-lingui-id: YcrXB2
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose the default currency that will apply"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Finnish translations for two new strings: 'Format' and 'Choose between Short and Full'. These need to be translated to maintain consistency in the Finnish localization.

Comment on lines +1073 to +1074
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose between Short and Full"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Translation string 'Choose between Short and Full' is missing (empty msgstr). This needs to be translated before merging.

Comment on lines +2614 to +2615
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Format"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: 'Format' is missing translation (empty msgstr). This field relates to currency display and needs to be translated.

Comment on lines +1072 to +1075
#. js-lingui-id: 2ZFG9X
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Choose between Short and Full"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for 'Choose between Short and Full'. This string should be translated to Spanish to maintain consistency.

Comment on lines +2614 to +2615
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx
msgid "Format"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for 'Format'. This key UI element needs to be translated to Spanish.

@FelixMalfait FelixMalfait merged commit 84b204d into main Jun 24, 2025
3 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch June 24, 2025 08:38
Copy link
Contributor Author

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5738:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5719:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:4609:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)�[39m
�[90m    at async consumeBody (node:internal/deps/undici/undici:5728:7)�[39m
danger-results://tmp/danger-results-8d4d339b.json

Generated by 🚫 dangerJS against 7e3fc8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant