-
Notifications
You must be signed in to change notification settings - Fork 3.6k
i18n - translations #12809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n - translations #12809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Large-scale internationalization update adding new currency format settings translations across multiple language files, with a focus on SettingsDataModelFieldCurrencyForm component strings.
- Added new translation strings 'Choose between Short and Full' and 'Format' across all language .po files
- Added generated TypeScript files (*.ts) in
packages/twenty-front/src/locales/generated/
for all supported languages with minified JSON translations - Several languages including cs-CZ, af-ZA, pl-PL have untranslated strings (empty msgstr fields) that need translation
- Missing Hungarian translations in
packages/twenty-front/src/locales/hu-HU.po
should be addressed for currency format settings
61 files reviewed, 14 comments
Edit PR Review Bot Settings | Greptile
#. js-lingui-id: 2ZFG9X | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose between Short and Full" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The new string 'Choose between Short and Full' is missing its French translation. This needs to be translated to maintain full localization coverage.
#. js-lingui-id: 2ZFG9X | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose between Short and Full" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Hungarian translation for 'Choose between Short and Full' string. This will cause English text to appear in a Hungarian UI context.
msgid "Choose between OIDC and SAML protocols" | ||
msgstr "Kies tussen OIDC en SAML protokolle" | ||
|
||
#. js-lingui-id: 2ZFG9X | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose between Short and Full" | ||
msgstr "" | ||
|
||
#. js-lingui-id: YcrXB2 | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose the default currency that will apply" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing translations for two new strings: 'Choose between Short and Full' and 'Format'. These need to be translated to maintain full Afrikaans language support.
#. js-lingui-id: kI1qVD | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Format" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Hungarian translation for 'Format' string. This will cause English text to appear in a Hungarian UI context.
#. js-lingui-id: 2ZFG9X | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose between Short and Full" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Missing Danish translation for 'Choose between Short and Full'. This should be translated to maintain consistency across the UI.
msgid "Choose between OIDC and SAML protocols" | ||
msgstr "Valitse OIDC- ja SAML-protokollien välillä" | ||
|
||
#. js-lingui-id: 2ZFG9X | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose between Short and Full" | ||
msgstr "" | ||
|
||
#. js-lingui-id: YcrXB2 | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose the default currency that will apply" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing Finnish translations for two new strings: 'Format' and 'Choose between Short and Full'. These need to be translated to maintain consistency in the Finnish localization.
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose between Short and Full" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Translation string 'Choose between Short and Full' is missing (empty msgstr). This needs to be translated before merging.
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Format" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: 'Format' is missing translation (empty msgstr). This field relates to currency display and needs to be translated.
#. js-lingui-id: 2ZFG9X | ||
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Choose between Short and Full" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing translation for 'Choose between Short and Full'. This string should be translated to Spanish to maintain consistency.
#: src/modules/settings/data-model/fields/forms/currency/components/SettingsDataModelFieldCurrencyForm.tsx | ||
msgid "Format" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing translation for 'Format'. This key UI element needs to be translated to Spanish.
Log
|
Created by Github action